jsx-eslint/eslint-plugin-react

[ESLint v5.9.0] Fix types

Open

#2,039 opened on Nov 9, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wanted

Description

A new option was added to ESLint. Reference: https://eslint.org/blog/2018/11/eslint-v5.9.0-released#the-fix-type-option

Should we start supporting this? If so, looks like "layout" is pretty obvious, but "problem" vs "suggestion" could be harder to tell. Or should we just set all recommended non-layout rules to "problem"?

Contributor guide

Tech stack
javascriptreact
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ESLint plugin basicsunderstanding of ESLint fix types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the ESLint v5.9.0 release notes for the fix type option (https://eslint.org/blog/2018/11/eslint v5.9.0 released#the fix type option). Examine existing rules in the plugin (e.g., in src/rules/) to understand current meta.fixable values. Determine a strategy for categorizing rules into 'layout', 'problem', or 'suggestion' based on rule intent. Decide whether to set all recommended non layout rules to 'problem' or require per rule analysis. Implement changes to each rule's meta.fixable property and add corresponding test updates.