jsx-eslint/eslint-plugin-react

Rule proposal: forbid superfluous enclosing spaces in same-line jsx components

Open

#191 opened on Aug 17, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wantednew rule

Description

This would produce a warning:

<span> { tab.title } </span>

as it produces 3 <span> DOM nodes (typically not wanted)

This wouldn't:

<span>{ tab.title }</span>

Contributor guide

Tech stack
javascriptreactnodejs
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of ESLint rulesFamiliarity with JSX syntaxJavaScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Explore the existing rules in eslint plugin react (e.g., jsx indent, jsx curly spacing) for patterns on implementing JSX lint rules. Create a new rule file that uses the JSXElement visitor to check for spaces inside JSXExpressionContainer. Specifically, detect when there is a whitespace node between the opening brace and the expression or between the expression and closing brace. Add the rule to the rules index and write test cases including the positive and negative examples from the issue. Consider using eslint plugin react's built in utilities for handling JSX.