jsx-eslint/eslint-plugin-react

react/prefer-stateless-function works different than described in docs

Open

#1901 opened on Jul 26, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
bughelp wanted

Description

For the react/prefer-stateless-function rule the docs for ignorePureComponents option states:

When true the rule will ignore Components extending from React.PureComponent that use this.props or this.context.

Actually it also ignore every PureComponent that use not only props or context, but ignores every component that use this. If this is not intended I prepared a fix (GH-1902), otherwise it makes sense to update the docs.

Contributor guide

Tech stack
javascriptreact
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ESLint rule developmentReact component patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the rule implementation in lib/rules/prefer stateless function.js and its test suite to confirm the behavior discrepancy. Check the linked PR (GH 1902) for a proposed code fix and ensure it aligns with the intended rule logic. Evaluate whether updating the documentation to match current behavior is simpler than fixing the code. Since the issue is old and has no recent activity, consider reaching out to maintainers for guidance on the preferred resolution path.