jsx-eslint/eslint-plugin-react

Detect uninitialized states and statefulness

Open

#1,778 opened on Apr 30, 2018

View on GitHub
聽(7 comments)聽(0 reactions)聽(0 assignees)JavaScript聽(8,630 stars)聽(2,797 forks)batch import
help wantednew rulequestion

Description

First things first, thank you for making this great plugin. 馃檶馃徎I'm hopeful that I will be able to contribute to this project. Maybe you can tell me if my two requests below make sense. Or maybe there are some rules which I do the job that I haven't discovered yet.

  • PureComponent detection works well but not the other way around: there are no errors thrown for using setState in a component declared as extends React.PureComponent.
  • In React 16.3, it eslint should warn if we have uninitialized state in a stateful component.

Contributor guide

Tech stack
javascriptreact
Domain
frontenddeveloper experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic ReactESLint plugin structureNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The contributor should examine existing rules like 'no set state in component' and 'no unused state' to understand patterns. Look at the component detection utilities in eslint plugin react's source code (likely in 'lib/util/'). Investigate React 16.3's constructor requirement for initializing state. Review the issue comments for any maintainer hints or related PRs.
Detect uninitialized states and statefulness 路 jsx-eslint/eslint-plugin-react#1778 | Good First Issue