jsx-eslint/eslint-plugin-react

Detect uninitialized states and statefulness

Open

#1,778 opened on Apr 30, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (2,797 forks)batch import
help wantednew rulequestion

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

First things first, thank you for making this great plugin. 🙌🏻I'm hopeful that I will be able to contribute to this project. Maybe you can tell me if my two requests below make sense. Or maybe there are some rules which I do the job that I haven't discovered yet.

  • PureComponent detection works well but not the other way around: there are no errors thrown for using setState in a component declared as extends React.PureComponent.
  • In React 16.3, it eslint should warn if we have uninitialized state in a stateful component.

Contributor guide

Research direction
Examine existing rules like 'no direct mutation state' and 'no unused state' to understand patterns. Implement two new rules: one to warn when setState is used in a PureComponent (should use props comparison), and another to warn when state is not initialized in a class component that uses setState.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptReactESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60