jsx-eslint/eslint-plugin-react

New Rule: Prevent boolean values for unknown props

Open

#1,695 opened on Feb 15, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wantedreact 16

Description

React 16 does not ignore Boolean values for unknown props anymore.

So while this code "worked" in react 15:

<div onClick={!disabled && onClick}/>

It would try to assing false to the DOM elements onClick handler when disabled === true (which would be ignored by the browser).

React 16 will print an error message in the console though.

How about a rule that does not allow boolean results for unknown props?

See https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html#changes-in-detail "Non-boolean attributes with boolean values"

Contributor guide

Tech stack
javascriptreactnodejs
Domain
frontendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React JSXESLint rule development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Implement a new ESLint rule that flags boolean values assigned to non boolean DOM props. Study the existing rule 'no unknown property' in lib/rules/ for pattern. The rule should check JSX attributes where the value is a boolean and the prop name is not a known boolean attribute. Test cases should be added in tests/lib/rules/. Reference the React 16 blog post for the behavior change. Check comments in issue #1695 for any additional guidance.