jsx-eslint/eslint-plugin-react

Bug: jsx-closing-bracket-location autofix removes whitespace character

Open

#1,501 opened on Oct 26, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,797 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

<div>
  foo </div>

Renders a space in HTML: <div>foo </div>

After fix is applied, it becomes:

<div>
  foo 
</div>

Note that there IS a space after foo in the output, however this space will typically be linted off by no-trailing-spaces rule, and even if it's not linted out of your source code, it will be ignored by React's JSX parser, meaning the output HTML will be <div>foo</div> 100% of the time.

tl;dr

<div>foo </div> becomes <div>foo</div>

Contributor guide

Research direction
Examine the autofix logic in the jsx closing bracket location rule to understand why it removes the trailing whitespace. Modify the fixer to preserve the whitespace before the closing bracket.
Tech stack
javascript
Domain
frontenddeveloper experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLintJSXReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65