jsx-eslint/eslint-plugin-react

Add functionsLast to sort-prop-types

Open

#1,465 opened on Oct 6, 2017

View on GitHub
 (0 comments) (3 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wanted

Description

Currently the sort-prop-types rule, allows you to set callbacksLast: true, which makes it so callbacks beginning with on are listed last.

I would like to see this expanded with a functionsLast: true option because I don't typically name my callbacks / functions with on.

Contributor guide

Tech stack
javascriptreact
Domain
frontendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint rule developmentReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the sort prop types rule implementation in lib/rules/sort prop types.js. Understand how callbacksLast is implemented and add a similar functionsLast option that treats any function prop type as last. Update tests and docs accordingly.