jsx-eslint/eslint-plugin-react

Add functionsLast to sort-prop-types

Open

#1,465 opened on Oct 6, 2017

View on GitHub
 (0 comments) (3 reactions) (0 assignees)JavaScript (2,797 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently the sort-prop-types rule, allows you to set callbacksLast: true, which makes it so callbacks beginning with on are listed last.

I would like to see this expanded with a functionsLast: true option because I don't typically name my callbacks / functions with on.

Contributor guide

Research direction
Examine the implementation of the `callbacksLast` option in the `sort prop types` rule. Then add a new `functionsLast` option that places function typed props (e.g., `PropTypes.func`) at the end of the sorted list.
Tech stack
javascriptreact
Domain
frontenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70