jsx-eslint/eslint-plugin-react

react/no-direct-mutation-state doesn't catch all cases

Open

#1,418 opened on Sep 8, 2017

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,731 forks)batch import
help wanted

Repository metrics

Stars
 (9,293 stars)
PR merge metrics
 (PR metrics pending)

Description

  const { model } = this.state;
  model.rating = rate;

In this case eslint won't show any errors.

Contributor guide

Research direction
Examine the no direct mutation state rule implementation to understand why it fails to catch mutation when state is destructured. Look at test cases for existing patterns and add a test case for destructured assignment. Then modify the rule's AST traversal to detect mutations on object properties obtained via destructuring.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60