jsx-eslint/eslint-plugin-react

react/no-direct-mutation-state doesn't catch all cases

Open

#1,418 opened on Sep 8, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wanted

Description

  const { model } = this.state;
  model.rating = rate;

In this case eslint won't show any errors.

Contributor guide

Tech stack
javascriptreact
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ESLint rulesUnderstanding of React's state mutation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
42
Research direction
The issue reports that the rule `react/no direct mutation state` fails to flag cases where a nested property of `this.state` is mutated indirectly, e.g., `const { model } = this.state; model.rating = rate;`. To fix this, examine the existing rule implementation in `lib/rules/no direct mutation state.js` and modify it to detect assignments to properties of objects retrieved from `this.state`. A possible approach is to track when a variable is assigned a value from `this.state` and then flag any subsequent member assignments on that variable. See issue #1418 and the rule's source code for details.