jsx-eslint/eslint-plugin-react

react/require-optimization warns when using PureRenderMixin.shouldComponentUpdate

Open

#1,019 opened on Jan 11, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wanted

Description

react/require-optimization reports the following as incorrect even though it follows Facebook's documentation for using PureRenderMixin with ES6 classes (link):

export class MyComponent extends React.Component {
    constructor(props) {
        super(props);
        this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this);
    }
}

I can try submitting a fix if you agree that this is actually a bug

Contributor guide

Tech stack
javascriptreact
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactESLint pluginsPureRenderMixin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the rule implementation for `react/require optimization` in the eslint plugin react repository. Look for the code that checks `shouldComponentUpdate` and determine why it flags cases where the method is assigned in the constructor via `PureRenderMixin.shouldComponentUpdate.bind(this)`. Consider modifying the rule to allow this pattern as per the Facebook documentation referenced in the issue.
react/require-optimization warns when using PureRenderMixin.shouldComponentUpdate · jsx-eslint/eslint-plugin-react#1019 | Good First Issue