Fix import of ../utils and ./utils

Open
#49 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
lua, react
Domain
tooling

Research direction

Start in react-devtools-shared/src/backend/renderer.luau around the utils import and compare the referenced utils location with the backend directory. Run the devtools setup or reproduction described in the issue, then verify that getUID(), getDisplayName(), and the other utils are available and devtools runs successfully.

Written by the indexing model from the issue text.

Description

I'm only able to get devtools to run (with rojo translating ../utils to script.Parent.Parent:WaitForChild('utils') if I change this in react-devtools-shared/src/backend/renderer.luau :

#ocal utils = require(script.Parent:WaitForChild('utils'))        # does not work
local utils = require(script.Parent.Parent:WaitForChild('utils'))  # does work

So, I think it should be this, because getUID() is in utils not backend/utils:

local utils = require("../utils")

https://github.com/jsdotlua/react-lua/blob/df4b4072e3aa78fc64850f8ca8b696084f305d75/modules/react-devtools-shared/src/backend/renderer.luau#L53-L70

Otherwise getUID() and getDisplayName() etc are nil.

Dominant language
Luau
Stars
569
Forks
25
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jsdotlua/react-lua

All issues in jsdotlua/react-lua

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.