jquery/sizzle

Limit all test suite selection operations to #qunit-fixture

Open

#375 opened on Jan 31, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,264 stars) (991 forks)batch import
help wanted

Description

Cf. jquery/jquery/issues/2880

This issue should close when one of the following two conditions are satisfied:

  • Someone adds a comment certifying that they have examined all unit tests and found no selections scoped so broadly that they could match QUnit output.
  • A commit lands on the master branch claiming to correct all such selections (e.g., by either scoping more tightly or—for those that are explicitly document-scope—reducing with jQuery#filter( "#qunit-fixture *" ) before comparing to expected results).

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of QUnitFamiliarity with Sizzle's test structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine all unit test files in the Sizzle repository, particularly those using QUnit. Look for any selector queries that might match elements outside #qunit fixture, such as document level selections. Either scope them more tightly or filter results with `jQuery('#qunit fixture *')` before comparing. Verify that no test selections could inadvertently match QUnit output elements. Reference the linked jQuery issue for context.