jquery-form/form

Access form from error callback

Open

#568 opened on Jan 16, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,199 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (5,209 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description:

Seem that error callback has not $form object to access it.

For example other callback have it, like:

        beforeSerialize: function($form, options) {
            // do something with $form
        },
       success: function(responseText, statusText, xhr, $form) {
            // do something with $form
       }

But error has only:

               error: function (xhr, status, error) {
                   // No $form object
                },

Expected Behavior:

               error: function (xhr, status, error, $form) {
                   // has $form now
                },

Or am I missing something?

Contributor guide

Research direction
Find where callbacks are set up in the plugin (likely in $.fn.ajaxForm or similar). Locate the error callback definition and add $form as a parameter, similar to other callbacks that receive it. Ensure $form is passed when invoking the error callback. Test with a sample form to verify.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75