jquery-form/form

Fortify SCA: Code Injection .

Open

#554 opened on Aug 3, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (2,199 forks)batch import
help wantedneed more info

Repository metrics

Stars
 (5,209 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Please review Instructions for Reporting a Bug.

Description:

I have no idea about whether it has been fixed in later versions. but the code scan is not passed.

Expected Behavior:

Actual behavior:

Source: jquery.form.js:812 Read xhr.responseXML() 810 var ct = xhr.getResponseHeader('content-type') || '', 811 xml = type === 'xml' || !type && ct.indexOf('xml') >= 0, 812 data = xml ? xhr.responseXML : xhr.responseText; 813 814 if (xml && data.documentElement.nodeName === 'parsererror') { Sink: jquery.form.js:781 setTimeout() 779 780 // clean up 781 setTimeout(function() { 782 if (!s.iframeTarget) { 783 $io.remove();

Versions:

jqform:3.51

Contributor guide

Research direction
Examine the code injection vulnerability in jquery.form.js around lines 812 and 781. The issue is that xhr.responseXML is used without sanitization, and setTimeout is called with dynamic content. Research how to safely parse XML responses and avoid code injection, possibly by using textContent or DOMParser with appropriate settings.
Tech stack
javascript
Domain
frontendsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptjQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60