jquery-form/form

Enable AND disable the `consistent-this` rule

Open

#553 opened on Jul 12, 2018

View on GitHub
聽(3 comments)聽(0 reactions)聽(0 assignees)JavaScript聽(5,209 stars)聽(2,199 forks)batch import
featurehelp wanted

Description

https://github.com/jquery-form/form/blob/master/src/jquery.form.js#L138

This line causes problems if we are concatenating with several other vendor pieces of code.

The only way to resolve this is to use dist/jquery.form.min.js, however it'd be great if we had a non-minified version in the dist folder as well 馃憤

Contributor guide

Tech stack
javascript
Domain
frontendbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the build configuration (likely Gruntfile or package.json scripts) in the repository. Add a task to copy the non minified 'src/jquery.form.js' into the 'dist' folder, possibly with a version suffix. Ensure that the concatenation issue mentioned in line 138 is resolved by using the non minified version in the distribution.
Enable AND disable the `consistent-this` rule 路 jquery-form/form#553 | Good First Issue