jquery-form/form

Enable AND disable the `consistent-this` rule

Open

#553 opened on Jul 12, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,199 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (5,209 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/jquery-form/form/blob/master/src/jquery.form.js#L138

This line causes problems if we are concatenating with several other vendor pieces of code.

The only way to resolve this is to use dist/jquery.form.min.js, however it'd be great if we had a non-minified version in the dist folder as well 👍

Contributor guide

Research direction
Inspect the line referenced in the issue and consider removing or modifying it to allow clean concatenation. Also, evaluate adding a non minified version to the dist folder.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75