jquery-form/form

Incompatible with jQuery 3 slim build

Open

#541 opened on Feb 22, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (5,209 stars) (2,199 forks)batch import
enhancementhelp wanted

Description

Hey there,

I've got the problem with this package while using Jquery 3.2.1. function ajaxForm is giving me an error: Cannot read property 'success' of undefined.

Someone on stackoverflow explained it there: https://stackoverflow.com/questions/45655409/website-using-jquery-form-version-4-2-2-and-jquery-3-

jQuery v3 introduces a lot of sweeping chances: one of which is the removal of the jqXHR.success() callback (it has been deprecated since v1.8, but many authors don't seem to bother to migrate/update). The plugin is obviously not updated to listen to resolution of promise using the jqXHR.done() callback.

Is there any chance to fix this problem?

Thank you ;)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptjQueryPromises
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Identify which file(s) contain the jqXHR.success() call (likely in the ajaxForm function). Replace each .success() with .done() and test with jQuery 3 slim build. Ensure no other deprecated methods are used. Review the StackOverflow link and issue comments for additional context.