jquery-form/form

.selector property is removed

Open

#353 opened on Aug 26, 2013

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,199 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (5,209 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

http://jquery.com/upgrade-guide/1.9/#selector-property-on-jquery-objects

As of 1.9, the .selector property is gone. Looks like it is still hanging around in in ajaxForm. Unless I am reading this wrong, .selector needs to be dealt with.

$.fn.ajaxForm = function(options) { options = options || {}; options.delegation = options.delegation && $.isFunction($.fn.on);

// in jQuery 1.3+ we can fix mistakes with the ready state
if (!options.delegation && this.length === 0) {
    var o = { s: this.selector, c: this.context };
    if (!$.isReady && o.s) {
        log('DOM not ready, queuing ajaxForm');
        $(function() {
            $(o.s,o.c).ajaxForm(options);
        });
        return this;
    }
    // is your DOM ready?  http://docs.jquery.com/Tutorials:Introducing_$(document).ready()
    log('terminating; zero elements found by selector' + ($.isReady ? '' : ' (DOM not ready)'));
    return this;
}

if ( options.delegation ) {
    $(document)
        .off('submit.form-plugin', this.selector, doAjaxSubmit)
        .off('click.form-plugin', this.selector, captureSubmittingElement)
        .on('submit.form-plugin', this.selector, options, doAjaxSubmit)
        .on('click.form-plugin', this.selector, options, captureSubmittingElement);
    return this;
}

return this.ajaxFormUnbind()
    .bind('submit.form-plugin', options, doAjaxSubmit)
    .bind('click.form-plugin', options, captureSubmittingElement);

};

Contributor guide