jpochyla/psst

Move away from using rustfm-scrobble

Open

#642 opened on Jun 17, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (7,282 stars) (183 forks)batch import
bughelp wanted

Description

This introduces an older version of UREQ and also introduces:

warning: the following packages contain code that will be rejected by a future version of Rust: wrapped-vec v0.3.0

This should be rewritten to fit ureq 3.0 and it shouldnt be too hard to do so esp. since we can use the code for that crate as a lot of inspiration.

Contributor guide

Tech stack
rust
Domain
desktopapi
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingHTTP client usageFamiliarity with Last.fm scrobbling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is to replace the rustfm scrobble dependency with direct usage of ureq 3.0. First, locate all usages of rustfm scrobble in the codebase (likely in scrobbling modules). Examine the functions provided by rustfm scrobble (e.g., authentication, track scrobbling) and understand the API endpoints used. Then, rewrite these interactions using ureq 3.0, referring to the source code of rustfm scrobble for request structures and response handling. The goal is to eliminate the warning about wrapped vec and ensure the scrobbling feature works as before. There are two comments in the issue that might provide additional context or guidance; check those for any maintainer suggestions.