jpochyla/psst

Hide artist catalogue sections when empty

Open

#571 opened on Dec 20, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (7,282 stars) (183 forks)batch import
buggood first issue

Description

Describe the bug There's some weird indentation on the related artist. I guess it's not indented because it doesn't fall within the catalog of the current artist, but when there's no items for this artist, we should probably hide the sections completely.

To Reproduce Find an artist (usually from credits link) that has no items in their catalogue.

Expected behavior Its weird to see related artists not indented? Is there a style solution for this?

Screenshots

Environment

  • OS: macOS
  • Version: Latest

Contributor guide

Tech stack
rust
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug is in the artist view section of the Psst Spotify client, likely in a Rust component responsible for rendering the catalogue. Look for where sections like 'Related Artists' are conditionally rendered, possibly in a function or widget that builds the artist page. The fix involves adding a check to hide the section when there are no items to display. Relevant files might include those handling artist UI, such as 'src/artist.rs' or similar component files. No open PRs or comments suggest a solution yet.
Hide artist catalogue sections when empty · jpochyla/psst#571 | Good First Issue