jpochyla/psst

Token fetching should happen async

Open

#492 opened on Jul 5, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (7,282 stars) (183 forks)batch import
good first issuehelp wanted

Description

Currently, when the application is opened and a token needs to be refetched, the window will not open until the token is retrieved. While this might make sense from a serialized loading perspective, it gives the impression that the entire application is stalling. We should load the token asynchronously and wait for it whilst the window loads simultaneously.

Contributor guide

Tech stack
rust
Domain
desktopperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustasync/awaitOAuth token flow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look for the token fetching logic in the codebase, likely in a module related to authentication or API client. Convert the synchronous token retrieval to an async function, and ensure the window loading does not block on it. Refer to existing async patterns in the codebase.