Support socks5:// protocol as client proxy protocol

Open Beginner friendly
#474 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
networking

Research direction

Start in client/client.go at lines 273-279, then compare the accepted proxy schemes with Go's net/http transport behavior linked in the issue. Done means the chisel client accepts socks5:// alongside the existing supported schemes and remains compatible with SOCKS proxy usage in Go programs.

Written by the indexing model from the issue text.

Description

The current version of chisel only allows the client to use socks:// or socks5h:// as proxy protocol:

However, Golang only supports the socks5:// proxy protocol for its HTTP client:

This leads to a conflicting situation when using a Go program that uses both the standard HTTP client and the chisel client and needs to go through a SOCKS proxy (such as the portainer agent).

Was there any reason to only allow for the socks:// instead of socks5:// in the chisel client?

Dominant language
Go
Stars
16.6k
Forks
1.6k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jpillora/chisel

All issues in jpillora/chisel

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.