joypixels/emojione

Generated Emojione.java is too large

Open

#516 opened on Jun 8, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (4,447 stars) (569 forks)batch import
bughelp wanted

Description

Unfortunately with the current amount of emojis the generated Java file for Android is too large, and the compiler complains with the error: "code too large".

I'd suggest to change the way emojis are loaded, in a similar way emoji-java[1] library is doing, by loading a JSON file instead of a hardcoded HashMap.

[1] https://github.com/vdurmont/emoji-java

Contributor guide

Tech stack
java
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaAndroid developmentJSON parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue reports that the generated Emojione.java file for Android is too large, causing a 'code too large' compiler error. The suggested fix is to load emoji data from a JSON file instead of a hardcoded HashMap, similar to the emoji java library (https://github.com/vdurmont/emoji java). Investigate how emoji java loads emojis from JSON at runtime and adapt the emojione code generation to output a JSON resource file and a Java class that parses it. The repository is archived, but the approach remains valid.