joshwcomeau/react-retro-hit-counter

More legible segments

Open

#1 opened on Jan 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (165 stars)
PR merge metrics
 (PR metrics pending)

Description

This component mimics a "seven-segment display": https://en.wikipedia.org/wiki/Seven-segment_display

I chose a simple implementation at first: each segment is exactly the same shape and size, and I'm just rotating them around.

Unfortunately, this means the end result isn't as legible as it could be, especially with thicker segments. Compare this component to another seven-segment display using trapezoids around the edge pieces:

current alternative

I think it would be good to move towards that alternative version, as the numbers are much easier to read.

Contributor guide

Research direction
Inspect the current seven segment display component, identify how segments are drawn, and update the shape for each segment to be a trapezoid instead of a rectangle to improve readability.
Tech stack
javascriptreact
Domain
frontenddesign
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75