joshwcomeau/guppy

Improve keyboard navigation in our forms

Open

#316 opened on Nov 1, 2018

View on GitHub
 (6 comments) (2 reactions) (0 assignees)JavaScript (151 forks)github user discovery
good first issue

Repository metrics

Stars
 (3,248 stars)
PR merge metrics
 (PR metrics pending)

Description

During my work on AppSettingsModal I've noticed that keyboard navigation through the form is not supported yet. I think it's needed to have a more native ux.

Describe the solution you'd like

  • Tab key should move the focus to the next form field forward and shift+tab backwards. Starting at the first element.
  • Project icon selection should support left, right, up & down navigation & enter key to move the focus out of the selection area.
  • Escape key should dismiss modals

Optional: Add navigation with left,right,up & down to move the focus.

Forms to check

  • CreateNewProjectWizard
  • ProjectConfigurationModal
  • AppSettingsModal

Note: There is more to improve e.g. keyboard navigation in sidebar & project page. But I think we should tackle this in a separate issue.

Contributor guide

Research direction
Study the existing modal components listed and implement tab navigation with Tab/Shift+Tab, arrow keys for icon selection, and Escape to close. Use React event handlers and focus management.
Tech stack
reactjavascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70