josdejong/mathjs

Expression rationalization gets stuck or takes too long (it worked in V9.5.1)

Open

#3,351 opened on Jan 16, 2025

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (1,298 forks)batch import
bughelp wanted

Repository metrics

Stars
 (13,832 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug Recently, I updated Math.js from version 9.5.1 to the latest version, and an expression rationalization that worked before doesn't work anymore. (see To Reproduce)

To Reproduce

import * as mathjs from 'mathjs';

const aa = mathjs.parse("6285.67^5/(s+6285.67)^5");
const bb = mathjs.rationalize(aa, {}, false); // It gets stuck here

console.log(bb.toString());

Contributor guide

Research direction
Investigate the changes in the rationalize function between version 9.5.1 and the latest, focusing on the expression '6285.67^5/(s+6285.67)^5'. Check for loops or recursion in the simplification algorithm that may cause infinite wait. Profile the execution to find the bottleneck.
Tech stack
javascript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptmath.js library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65