josdejong/mathjs

simplify `sqrt(x)*sqrt(x)`

Open

#3231 opened on Jul 10, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (13,832 stars) (1,298 forks)batch import
featurehelp wanted

Description

I asked it to simplify sqrt(x)*sqrt(x) and it couldn't do it. Nor could it do really anything with sqrt. As soon as I added the following single rule, it works perfectly and does all the things you would hope it should know how to do!

const simpRules = [...(math.simplify.rules)];
simpRules.push('sqrt(n1) -> n1^0.5');
math.simplify(exp,simpRules);

I suggest adding 'sqrt(n1) -> n1^0.5' to simplify.js

Contributor guide

Tech stack
javascriptnodejs
Domain
backendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue asks to add a simplification rule for sqrt. The current implementation in simplify.js does not include a rule to transform sqrt(n) to n^0.5. A contributor can locate the simplify.js file in the source code, find the array of rules, and append the rule 'sqrt(n1) > n1^0.5' (or equivalent using math.js's rule syntax). The existing rule set can be extended by adding this single rule. Testing should include verifying that sqrt(x)*sqrt(x) simplifies to x.