josdejong/mathjs

simplify `sqrt(x)*sqrt(x)`

Open

#3,231 opened on Jul 10, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,298 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (13,832 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I asked it to simplify sqrt(x)*sqrt(x) and it couldn't do it. Nor could it do really anything with sqrt. As soon as I added the following single rule, it works perfectly and does all the things you would hope it should know how to do!

const simpRules = [...(math.simplify.rules)];
simpRules.push('sqrt(n1) -> n1^0.5');
math.simplify(exp,simpRules);

I suggest adding 'sqrt(n1) -> n1^0.5' to simplify.js

Contributor guide

Research direction
Open the simplify.js file in the mathjs repository and add the rule 'sqrt(n1) > n1^0.5' to the list of simplification rules.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptmathjs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85