josdejong/mathjs

Property 'Unit' does not exist on type 'MathJsStatic'. Did you mean 'unit'? error in Typescript

Open

#2,286 opened on Jul 14, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,298 forks)batch import
help wantedtypescript

Repository metrics

Stars
 (13,832 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When creating the following code in Typescript

import { MathJsStatic, create, all, MathType } from 'mathjs';
const math: MathJsStatic = create(all, {}) as MathJsStatic;

math.createUnit('cells'); // works perfectly
math.Unit; // results in: Property 'Unit' does not exist on type 'MathJsStatic'. Did you mean 'unit'?

It looks like Unit isn't properly part of the new MathJS typescript definitions or it's not linking correctly.

if I replace the line above with window['testing'] = math then the Unit is in fact present.

image

Edit: I am running mathjs 9.4.4 without @types/mathjs (relying on the built-in type definitions)

Contributor guide

Research direction
Inspect the mathjs type definitions in `index.d.ts` for the `MathJsStatic` interface. Confirm that `Unit` is missing. Check how `createUnit` works and its return type. Add the missing `Unit` declaration to the interface, ensuring it matches the runtime constructor. Test with a TypeScript file.
Tech stack
typescriptjavascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65