josdejong/mathjs

Remove support for Object literals as scope objects

Open

#2,165 opened on Apr 10, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (13,832 stars) (1,298 forks)batch import
featurehelp wanted

Description

PR #2166 adds a warning that support for bare objects as scopes will be removed in a future release.

This issue is for the removal of support, in that future release.

const scope = {}
math.evaluate("constructor(foo) = foo", scope)

should error.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with mathjs APIunderstanding of deprecation patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Check PR #2166 for the warning implementation. The removal should be done in the same areas where the warning was added, likely in the evaluate function in src/expression/function/evaluate.js or similar. Ensure that passing a plain Object as scope throws an error instead of just warning.