josdejong/mathjs

[Document the] secant function messing up sec unit

Open

#2,095 opened on Jan 28, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,298 forks)batch import
documentationhelp wanted

Repository metrics

Stars
 (13,832 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I believe "sec" is a built-in alias for the time unit seconds. However, if I type "5 sec" into the https://mathnotepad.com (or the evaluate input on https://mathjs.org) the function sec seems to take precedence and throw a TypeError even though it is expecting a unit:

TypeError: Unexpected type of argument in function multiplyScalar (expected: number or Unit or string or boolean or BigNumber or Complex or Fraction, actual: function, index: 1)

Can we improve the parser to avoid this confusion? It seems the unit "sec" is currently unavailable.

Contributor guide

Research direction
Investigate the parser code to understand how unit aliases and function names are resolved. Identify where 'sec' is being parsed as a function before a unit. Propose a change to prioritize unit aliases over function names when parsing expressions.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70