josdejong/mathjs

Removing user-defined units

Open

#2,081 opened on Jan 13, 2021

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (1,298 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (13,832 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there a way to remove user-defined units? I create units for currency conversion using:

math.createUnit('USD', {aliases: ['usd']})

var rates = currencyRates //Rates in json format
Object.keys(rates).map((currency) => {
    math.createUnit(rates[currency].code, {
        definition: math.unit(rates[currency].inverseRate + 'USD'),
        aliases: [rates[currency].code.toLowerCase()]
    }, {
        override: true
    })
})

But if I no longer want to use currencies, is there a way to remove them without creating a new mathjs instance (in my case without refreshing browser window)? If not, may I suggest introducing a math.removeUnit() method?

Contributor guide

Research direction
Implement a math.removeUnit() method to remove user defined units. Study the existing unit creation and management code in mathjs, and propose a design that allows deletion without breaking existing units that depend on the removed unit.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75