josdejong/jsoneditor

Change the shortcut keys in tooltip titles to show `cmd` on Mac instead of `ctrl`

Open

#1,628 opened on Nov 11, 2024

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
bughelp wanted

Description

It would be nice if we could disable tool tips as a feature. Maybe adding an option "toolTips: false". I don't need these toolTips and therefore have to collect all nodes with a title attribute in the DOM and remove the attribute. Not so elegant. What do you think?

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of keyboard eventsFamiliarity with JSON Editor's UI code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests platform specific shortcut key display (cmd on Mac, ctrl on other). Look for where tooltip titles are set in JSON Editor's UI components, likely in src/js/ or similar. Use navigator.platform to detect Mac and conditionally display 'cmd' instead of 'ctrl'. The title suggests changes to tooltip titles specifically, so focus on the tooltip rendering code. No linked PRs or comments indicate prior work, so this is a fresh feature.