josdejong/jsoneditor

Label 'Preview' is not associated with its edit field present under 'Transform' dialog box.

Open

#1,573 opened on Feb 15, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
featurehelp wanted

Description

Test Environment OS Version: Windows 11 Version 22H2 (OS Build 23619.1000) Browser: Edge Version 121.0.2277.83 (Official build) (64-bit)

Repro Steps 1.Open URL - jsoneditor-example - CodeSandbox 3.Navigate to 'Filter' button in the code editor and activate it. 4.Transform dialog will get open. 5.Navigate to 'Preview' edit field and observe the issue.

Actual Result Label 'Preview' is not associated with its edit field present under 'Transform' dialog box.

Expected Result Label 'Preview' should be associated with its edit field present under 'Transform' dialog box.

Attachment

https://github.com/josdejong/jsoneditor/assets/93735775/0546f06d-246c-462b-89b6-ee6ba9c73db7

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendaccessibility
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic HTMLaccessibility basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for the Transform dialog component in the source code, likely in an HTML template or JSX. Identify the edit field labeled 'Preview' and its associated label element. Modify the label to use the 'for' attribute or wrap the input, or add 'aria labelledby' to associate them properly. The fix should ensure screen readers announce the label when the field is focused.