josdejong/jsoneditor

oneOf issue

Open

#1,548 opened on Sep 13, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
featurehelp wanted

Description

Hi.

Take a look on the example https://sgurin.github.io/jsoneditor/examples/26_autocomplete_by_schema.html

When I am trying to set profession -> level there is only one option available

image

but schema contains 3 refs

  "profession": {
    "oneOf": [
      {
        "$ref": "junior"
      },
      {
        "$ref": "experienced"
      },
      {
        "$ref": "senior"
      },
    ]
  },

Looks like refs don't work

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JSON schema basicsJavaScript debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the autocomplete feature in jsoneditor, particularly how it resolves oneOf schemas with $ref. The issue is that when a property uses oneOf with $ref, the autocomplete only shows one option instead of all. Likely the autocomplete logic is not following $ref references inside oneOf. Look at the autocomplete related code (e.g., src/js/autocomplete.js or similar) to understand how suggestions are generated from the schema. Check if there is a function that resolves $ref before processing oneOf. Consider adding a step to resolve all $ref within oneOf before generating suggestions. The issue can be reproduced using the example at https://sgurin.github.io/jsoneditor/examples/26 autocomplete by schema.html.