josdejong/jsoneditor

JSON Editor doesn't create Dropdowns for Arrays

Open

#1,473 opened on Oct 4, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
bughelp wanted

Description

JSON Editor won't create Dropdowns for Object Property, if the objects are in an array.

So I've been using JSON Schema enum's to make the app's stakeholders life easier (and validate the input), but I've noticed a weird bug when using array of objects. Basically, a Popover dialog will be shown for the property that says "should be equal to A, B, or C", but dropdown won't be displayed.

I've tried using enum on a object property (object not in an array), and Dropdowns are being rendered as defined.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptJSON Schema understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate why dropdowns (based on enum values) are not rendered for object properties when the objects are inside an array. Look at the code that handles JSON Schema validation and UI generation for array items. Check the source files in src/ directory, particularly those dealing with schema parsing and component creation for arrays. The bug may be in how the editor traverses schema definitions for array elements. A test with a schema containing an array of objects with enum on a property should be created to reproduce the issue. The fix likely involves adjusting the code that creates form elements for array items to respect enum constraints.
JSON Editor doesn't create Dropdowns for Arrays · josdejong/jsoneditor#1473 | Good First Issue