josdejong/jsoneditor

Autocompletion: supporting self references

Open

#1,450 opened on Jul 7, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
bughelp wanted

Description

Hi,

Look like self references are not supported by the schema autocompletion feature. For example, on self key in the example below:

   {
        "type": "object",
        "properties": {
            "self": {
                "$ref": "#"
            },
            "bar": {
                "type": "string",
                "enum": [
                    "A",
                    "B"
                ]
            }
        },
        "additionalProperties": false
    }

Contributor guide

Tech stack
javascript
Domain
frontendtoolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JSON schemaJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look into the autocompletion code, likely in a file like 'src/js/autocomplete.js' or similar. The issue provides a minimal schema example that triggers the missing self reference behavior. The solution likely involves resolving '$ref' to the root schema when the reference is '#' within the schema object itself. Check existing tests for autocompletion to ensure no regressions.