josdejong/jsoneditor

Allow access to the Ace editor instance

Open

#1,202 opened on Dec 26, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,034 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (10,781 stars)
PR merge metrics
 (Avg merge 15h 36m) (3 merged PRs in 30d)

Description

Please add the aceEditor property to the documentation and the @types so we can make small adjustments like controlling the minLines and maxLines settings?

Technically there is nothing preventing access. The property doesn't exist in the TypeScript declarations but that is easy to work around. But this change would just make things official and then it is unlikely that the property will become private or be renamed in the future.

Contributor guide

Research direction
Add the `aceEditor` property to the TypeScript declarations file (e.g., index.d.ts) and update the API documentation to mention that `aceEditor` is accessible.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80