josdejong/jsoneditor

Allow access to the Ace editor instance

Open

#1,202 opened on Dec 26, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (10,781 stars) (2,034 forks)batch import
featurehelp wanted

Description

Please add the aceEditor property to the documentation and the @types so we can make small adjustments like controlling the minLines and maxLines settings?

Technically there is nothing preventing access. The property doesn't exist in the TypeScript declarations but that is easy to work around. But this change would just make things official and then it is unlikely that the property will become private or be renamed in the future.

Contributor guide

Tech stack
javascripttypescript
Domain
frontenddocumentation
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basicsJSON editor library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests adding an `aceEditor` property to the TypeScript declarations and documentation. The property already exists internally but is not officially exposed. Look for the TypeScript declaration files (e.g., `index.d.ts`) in the repository and add the property. Also update the documentation (likely a README or website) to mention this property. Check the current code to ensure the property is accessible.
Allow access to the Ace editor instance · josdejong/jsoneditor#1202 | Good First Issue