josdejong/jsoneditor

Attach custom classnames to the DOM root of a node instead of nested inside

Open

#1,088 opened on Aug 17, 2020

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (2,034 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (10,781 stars)
PR merge metrics
 (Avg merge 15h 36m) (3 merged PRs in 30d)

Description

Another small suggestion for a neater design! Would be fantastic for the onCreateMenu callback to be able to return undefined and have the rendering of the context menu icon skipped or set to display:none. This way the tree view can more easily convey at a glance which of the elements may have context actions for those of us that are replacing the menu with our own actions.

JSONEditorOptions.onCreateMenu?: ((menuItems: MenuItem[], node: MenuItemNode) => MenuItem[]) | undefined
=>
JSONEditorOptions.onCreateMenu?: ((menuItems: MenuItem[], node: MenuItemNode) => MenuItem[] | undefined) | undefined

Alternatively, an isEmpty check of the MenuItem array would do the same job.

Cheers!

Contributor guide

Research direction
Examine the onCreateMenu callback implementation and the context menu rendering logic in the source code. Modify the type definition and the rendering code to handle 'undefined' return or an empty array from the callback, then add a test case.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70