jopohl/urh

AM-FSK (AM/FSK) interpretation and generation

Open

#806 opened on Oct 10, 2020

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (10,093 stars) (859 forks)batch import
discussionfeaturehelp wanted

Description

Hi!

I'm trying to interpret a signal that is both AM and FSK modulated. An FSK signal that is in turn amplitude modulated. Because of this URH will not demodulate the signal correctly since it is not possible to do both AM and FSK demodulation as far as I understand. I'm too inexperienced to say that this isn't possible to perform in URH today but I have no idea how to accomplish that.

Unless this feature already exist I suppose that some kind of layered demodulation/modulation functionality in URH would be required.

Being quite a novice in this field I guess that the signal otherwise could be AM-demodulated in some other software and then fed into URH. Being that I also would like to generate signals as well that feels quite cumbersome however.

Any feedback regarding this would be greatly appreciated. Thanks!

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of AM and FSK modulationFamiliarity with URH's demodulation architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requests the ability to demodulate and generate signals that are both AM and FSK modulated. To implement this, investigate URH's current demodulation pipeline, likely in the demodulation plugin directory (e.g., src/urh/plugins/demodulation). Look for existing classes for AM and FSK demodulation and consider creating a composite demodulator that applies AM demodulation first followed by FSK demodulation, or vice versa. For generation, a similar layered approach would be needed. Check if any related issues or PRs mention similar work. The main challenge is handling the combined modulation without losing information; a research prototype could be developed as a new plugin or extension to the existing framework.