jonkemp/gulp-qunit

gulp-qunit.finished event emitted to wrong target

Open

#38 opened on Jun 7, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (19 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (24 stars)
PR merge metrics
 (PR metrics pending)

Description

In https://github.com/jonkemp/gulp-qunit/pull/13/files, the event was emitted to gulp stream. (because this binded to through) But in https://github.com/jonkemp/gulp-qunit/commit/734543fa81a725da1acfc91695e602de543b277b, the event was emitted to the child process. So users cannot listen to the event from outside.

Contributor guide

Research direction
Investigate the event emission difference between the pull request and the commit. Trace where the 'finished' event is emitted and ensure it is emitted to the gulp stream so users can listen from outside.
Tech stack
javascriptnodejs
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60