jondot/logolang.org

Add support for comments

Open

#5 opened on Jan 9, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (0 forks)github user discovery
good first issue🦀 Rust

Repository metrics

Stars
 (11 stars)
PR merge metrics
 (PR metrics pending)

Description

Comments are not implemented right now but can be very simple:

  • Comments start with ;, like Lisp
  • Start of line, or end of line
  • You can trim it as first step before tokenizing code (this way, the parser/ast are ignorant of comments)
  • Prefer not using regex, but if you have to, it's good enough (because in the future, we'll be happy to get rid of the regex crate, which only does tokenization for now)

Contributor guide

Research direction
Implement comment removal by trimming lines starting with ';' before tokenization. Avoid modifying the parser or AST.
Tech stack
rust
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80