jonas-schievink/rubble

Don't give up when missing the initial transmit window

Open

#77 opened on Sep 28, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Rust (58 forks)user submission
area: link layergood first issuestatus: needs codetype: bug

Repository metrics

Stars
 (403 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently the link layer will abort the connection when it does not receive the initial connect event:

https://github.com/jonas-schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338-L345

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

Contributor guide

Research direction
Check the BLE specification for the connection establishment procedure, especially the initial transmit window. Then modify the link layer code around the highlighted lines (connection.rs:338-345) to handle the case when the initial connect event is not received. The comment in the code suggests the intended behavior; implement that and verify against the spec.
Tech stack
rust
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65