jonas-schievink/rubble

Don't give up when missing the initial transmit window

Open

#77 opened on Sep 28, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Rust (403 stars) (58 forks)user submission
area: link layergood first issuestatus: needs codetype: bug

Description

Currently the link layer will abort the connection when it does not receive the initial connect event:

https://github.com/jonas-schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338-L345

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of RustFamiliarity with BLE connection establishment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue points to lines 338-345 in connection.rs (https://github.com/jonas schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338 L345) where the code aborts on missing initial transmit window. The fix should implement the comment's suggestion and check against the Bluetooth specification to properly handle this scenario without aborting. Reviewing the BLE core spec and similar implementations would be necessary to determine the correct behavior.
Don't give up when missing the initial transmit window · jonas-schievink/rubble#77 | Good First Issue