jlfwong/speedscope

Increase unit precision when zoomed in far enough for markers to be identical

Open

#199 opened on Jan 23, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (4,040 stars) (181 forks)batch import
help wanted

Description

speedscope: image

chrome://tracing image

See: https://twitter.com/erwincoumans/status/1088136572271128576

My proposed fix would be the alter the unit formatting if two or more on-screen markings are identical. There may be some trickiness in ensuring that the markers don't overlap one another.

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptWeb development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the rendering code for unit markers, likely in the zoom logic and time axis formatting. Look for files handling canvas or SVG drawing of markers, and understand how precision is determined. Check the repository's source for any existing tests or comments about marker overlap. Consider examining the linked tweet for visual reference.