jlfwong/speedscope

Format support: Import from pyflame

Open

#146 opened on Aug 21, 2018

View on GitHub
 (1 comment) (3 reactions) (0 assignees)TypeScript (4,040 stars) (181 forks)batch import
charity donation bountyhelp wantedimport source

Description

This could either by done by contributing an importer to speedscope like we have for stackprof (https://github.com/jlfwong/speedscope/blob/100578c536a3afab39fb6803d28913d12eac29c5/src/import/stackprof.ts), or by contributing a speedscope file format outputter to pyflame, like I did for rbspy (https://github.com/rbspy/rbspy/pull/161)

Contributor guide

Tech stack
typescript
Domain
performancetoolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptperformance profiling conceptsreading existing importer code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Look at the existing importer for stackprof at src/import/stackprof.ts to understand the structure. Then implement a similar importer for pyflame format, or contribute to pyflame to output speedscope format. The rbspy PR (https://github.com/rbspy/rbspy/pull/161) provides an example of the latter approach.