jlegewie/zotfile

Truncation of displayed collection path during rename operation

Open

#202 opened on Dec 11, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (3,511 stars) (276 forks)batch import
bughelp wanted

Description

There is a minor but bothersome issue that exists in certain situations when using the "Rename Attachments" command. Normally, if the user is sorting attachments into subfolders based on collections, a list prompt is displayed for items that exist in multiple collections. The width of the prompt window is determined by the length of the item's title, and not by the longest path in the list. If an item that is nested deeply has a relatively short title, the collection path will be truncated. a-fs8 I don't know if it's possible to specify the exact width of the prompt window. A kludge that I've implemented for myself simply involves concatenating a long string of whitespace to the end of the title (specifically, to the 'message' variable here in zotfile.js). This indirectly sets a minimum window size. c-fs8

Contributor guide

Tech stack
javascript
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptZotero plugin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is in the rename attachments dialog where the collection path gets truncated. The problem is likely in the code that creates the prompt window; the width is set based on the item title instead of the longest path. Look at the line referenced (around line 1684 in chrome/content/zotfile/zotfile.js) where the 'message' variable is constructed. A fix could calculate the maximum path length among the displayed collections and set the window width accordingly, or add padding to ensure the path is not cut off.