jj-vcs/jj

FR: `revsets.push`

Open

#3,650 opened on May 8, 2024

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Rust (28,830 stars) (1,052 forks)batch import
good first issuepolish🪒🐃

Description

Is your feature request related to a problem? Please describe. basically, #2434. except i have a custom revset i'd like to use instead of whatever the default may end up being

Describe the solution you'd like a new config option akin to revsets.log: revsets.push

Describe alternatives you've considered since push is backend-specific behavior, it might be better to make the new config key git.push-revset instead. (NB would be nice to do some config squashing, ie git.push.revset, but that's a larger change)

Contributor guide

Tech stack
rust
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of RustFamiliarity with jj configurationUnderstanding of Git push mechanics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the existing 'revsets.log' configuration option in the codebase (likely in the configuration module). Understand how revset customizations are parsed and applied. Also review the Git backend's push behavior to determine where the revset would be used. Consider the alternatives mentioned, such as 'git.push revset' or squashing config under 'git.push.revset'.