jippi/hashi-ui

Blank value in client Meta Properties causes key/value mismatch

Open

#454 opened on Aug 8, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,235 stars) (157 forks)batch import
bughelp wanted

Description

In my client nomad config, I have:

  "client": {
    "enabled": true,
    "max_kill_timeout": "10m",
    "meta": {
      "key_a": "value_a",
      "key_b": "value_b",
      "key_c": "",
      "key_d": "value_d",
      "key_e": "value_e"
    },

This results in the UI client page displaying:

Meta Properties
key_a: value_a
key_b: value_b
key_c: value_d
key_d: value_e
key_e:

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptUI development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate how client meta properties are parsed and rendered in the UI. Look for files that handle the 'meta' object, possibly in a component that displays client details. Ensure that when a meta value is an empty string, it does not shift the key value pairing. Consider checking the template or rendering logic that iterates over meta entries.