jimp-dev/jimp

Dark Diff

Open

#887 opened on May 15, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (785 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (13,218 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected Behavior

Dark backgrounds when diffing images together instead of the opaque light background

Current Behavior

The backgrounds still appear light

Failure Information (for bugs)

A diff with a white opaque background is produced

Steps to Reproduce

const snapshotA = await Jimp.read(fileA)
snapshotA.background(0x00000000)

const snapshotB = await Jimp.read(fileB)
snapshotB.background(0x00000000)

const diff = Jimp.diff(snapshotA, snapshotB, mismatchThreshold)

Screenshots

Context

  • Jimp Version: 0.10.3
  • Operating System: Mac OS Catalina 10.15.3
  • Node version: v10.18.1

Contributor guide

Research direction
Inspect the Jimp.diff function to understand how background is handled during comparison. Look for where the diff image background is set and modify it to respect the input images' background settings.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75