jimp-dev/jimp

How to align with percentages in cover and contain?

Open

#740 opened on May 20, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (785 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (13,218 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected Behavior

I want to align an image as I would in browser with following css:

object-fit: cover;
object-position: center 20%;

Current Behavior

cover() only excepts alignBits

Contributor guide

Research direction
Investigate how `cover()` currently handles alignment and extend it to accept percentage values (e.g., `cover(src, { align: { x: 'center', y: '20%' } })`). Look at CSS `object fit` and `object position` for reference. You may need to modify the internal resizing logic to support relative positioning.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50