jimp-dev/jimp

Dither not working

Open

#1,001 opened on Apr 7, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (13,218 stars) (785 forks)batch import
bughelp wanted

Description

Expected Behavior

this image example to something like this dithered_image

Current Behavior

this image example to this image dithered_image there is just nothing happening

Failure Information (for bugs)

the image is not being dithered

Steps to Reproduce

my code snippet:


Jimp.read('./server/images/example.png', async function (err, image) {
            
            async function dithering() {
                console.log('dithering', file)

                image.dither565()
                image.write(`./server/images/dithered_image.png`)


                file = `./server/images/dithered_image.png`
            } 
     //...
     //...
  1. step 1: dither the image
  2. step 2: see the result

Context

  • Jimp Version: 0.16.1
  • Operating System: Windows 10 64 bit
  • Node version: v14.16.0

Failure Logs

no errors / logs

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsJimp basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the implementation of the `dither565` method in Jimp. Check the source code for the dithering algorithm, likely in `packages/core/src/` or similar. Look for any changes in behavior between versions, especially since the user reports no errors nor logs. Consider adding debug logging to trace the pixel manipulation. Check if there are any existing test cases for dithering that might indicate the expected behavior.