jieter/django-tables2

Default value not respected on export

Open

#710 opened on Oct 30, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,693 stars) (417 forks)batch import
Help wanteddocs

Description

I use the default value heavily in my tables, but noticed that default is not respected when I export tables.

It's the following code in django_tables2/rows.py

    def get_cell_value(self, name):
        """
        Returns the final rendered value (excluding any html) for a cell in the
        row, given the name of a column.
        """
        return self._get_and_render_with(
            self.table.columns[name], render_func=self._call_value, default=None
        )

As you can see, default=None is passed to get_and_render_with, effectively ignoring the default value.

Is there a reason for this? If there is, should we document it? Happy to contribute.

Thanks for the great library.

Contributor guide

Tech stack
pythondjango
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonDjangodjango tables2
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the `get cell value` method in `django tables2/rows.py`. Understand how ` get and render with` works and how column defaults are defined. The fix likely involves passing the column's default value instead of `None`. Look at related tests in the repository to ensure correctness.