jieter/django-tables2

Ordering of missing values for ListData

Open

#529 opened on Jan 11, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (1,693 stars) (417 forks)batch import
Help wanted

Description

Missing values in List of dicts table are pulled to the top when using ascending sorting. This might be unexpected for some users, therefore it would be convenient having an "order_null_last" or similar parameter in table meta/kwargs. I've made a hard-coded quick fix in a fork here: https://github.com/usajusaj/django-tables2/commit/ec27b7ff5915bee1fc0c431c00696599c9107311 but that's far from being a proper solution.

Contributor guide

Tech stack
python
Domain
backenddatabase
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of DjangoFamiliarity with django tables2
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue requests a parameter to control null ordering in ListData tables. A reference implementation is in commit ec27b7ff of a fork. To implement, modify the sorting logic in django tables2's table or column classes to support an optional 'order null last' parameter. Review the existing sorting methods and ensure compatibility with different backends. Start by examining the table's `order by` processing and the `Column` class for where null ordering is determined.